New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: fix let
logic in for-in and for-of loops in no-extra-parens
#14011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Jan 18, 2021
nzakas
approved these changes
Jan 28, 2021
btmills
approved these changes
Jan 30, 2021
This looks to have broken |
It seems that |
Fixed in @typescript-eslint/eslint-plugin v4.15.0 |
This was referenced Mar 5, 2021
This was referenced Mar 17, 2021
Merged
eslint-github-bot
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Jul 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
What parser (default,
@babel/eslint-parser
,@typescript-eslint/parser
, etc.) are you using?default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo
What did you expect to happen?
Per the ForInOfStatement specification,
ForInStatement#left
expression cannot start with let[, andForOfStatement#left
expression cannot start with let:So, I would expect:
for ((let) in foo);
for ((let.a) of foo);
What actually happened? Please include the actual, raw output from ESLint.
for ((let) in foo);
for ((let.a) of foo);
After the autofix:
for (let.a of foo);
is indeed a syntax error in engines:Espree currently allows that, but it shouldn't. Reported acornjs/acorn#1009
What changes did you make? (Give an overview)
Split
"ForInStatement, ForOfStatement"(node)
into two functions, as they're already different enough, and fixed the logic about expressions starting withlet
identifier.Is there anything you'd like reviewers to focus on?
This fix produces more warnings for
for-in
loops and fewer warnings forfor-of
loops.This is similar to the previous fix for
for
loops #13981